From bb493700f0e521ed12bad14a67d3e27bd2b00545 Mon Sep 17 00:00:00 2001 From: YuehuCao Date: Mon, 28 Jul 2025 10:52:28 +0800 Subject: [PATCH] refactor(services): remove unreachable code - Delete redundant logic after line 22's early return --- apps/notification/backend/services/email_sender_service.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/apps/notification/backend/services/email_sender_service.py b/apps/notification/backend/services/email_sender_service.py index a91b680..d4fa881 100644 --- a/apps/notification/backend/services/email_sender_service.py +++ b/apps/notification/backend/services/email_sender_service.py @@ -33,10 +33,8 @@ class EmailSenderService: await doc.set({"email_senders": updated_list}) return {"success": True, "email_senders": updated_list} else: - if not new_senders: - return {"success": False, "msg": "No sender provided"} - doc = await self.set_email_sender(tenant_id, new_senders) - return {"success": True, "email_senders": doc.email_senders} + result = await self.set_email_sender(tenant_id, new_senders) + return result # remove the email sender from the list async def remove_email_senders(self, tenant_id: str, emails_to_remove: list):