From 52f87152410eb5b223e092d5da4d1d365b73c1af Mon Sep 17 00:00:00 2001 From: icecheng Date: Wed, 3 Sep 2025 16:36:33 +0800 Subject: [PATCH] feat(devops): If ttl_hours < 0, the deployment will take effect permanently --- apps/devops/app/common/models/deployment/deployment.py | 2 +- apps/devops/app/routes/deployment/service.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/devops/app/common/models/deployment/deployment.py b/apps/devops/app/common/models/deployment/deployment.py index b2c719a..ef576c6 100644 --- a/apps/devops/app/common/models/deployment/deployment.py +++ b/apps/devops/app/common/models/deployment/deployment.py @@ -45,7 +45,7 @@ class InitDeploymentRequest(BaseModel): target_env: Literal["alpha", "prod"] user_id: str reason: str = "not provided" - ttl_hours: int = 3 + ttl_hours: int = -1 class CheckDeploymentStatusRequest(BaseModel): product_id: str diff --git a/apps/devops/app/routes/deployment/service.py b/apps/devops/app/routes/deployment/service.py index 650dd8d..be1aa99 100644 --- a/apps/devops/app/routes/deployment/service.py +++ b/apps/devops/app/routes/deployment/service.py @@ -179,8 +179,8 @@ class DeploymentService: triggered_user_id=deployment.deployed_by, causes=deployment.deployment_reason, target_env=deployment.deployment_target_env, - ttl_control=True, - ttl=deployment.deployment_ttl_hours * 60 * 60, + ttl_control=deployment.deployment_ttl_hours > 0, + ttl=10800 if deployment.deployment_ttl_hours < 0 else deployment.deployment_ttl_hours * 60 * 60, commit_sha256=deployment.deployment_git_sha256, ) # send request to reoncile service