icecheng/freeleaps-service-hub
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request 'fix: remove problematic ModuleLogger dependencies from startup events' (#73) from Nicolas_service_hub into dev

Browse Source 
Reviewed-on: freeleaps/freeleaps-service-hub#73
This commit is contained in:
icecheng 2025-09-26 02:25:46 +00:00
commit 41bb6e7a73
3 changed files with 5 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
apps/notification/webapi/bootstrap/freeleaps_app.py
View File

@ -3,8 +3,6 @@ from backend.infra.rabbitmq.async_subscriber import AsyncMQSubscriber
from backend.models.constants import NotificationChannel
from webapi.utils.email_consumer import EmailMQConsumer
from webapi.utils.sms_consumer import SmsMQConsumer
from common.log.module_logger import ModuleLogger
from common.config.app_settings import app_settings
class FreeleapsApp(FastAPI):
@ -24,15 +22,13 @@ class FreeleapsApp(FastAPI):
async def start_consumers():
print("starting up!")
# Add startup logging
module_logger = ModuleLogger(sender_id="ApplicationBootstrap")
await module_logger.log_info(
text=f"Notification service started successfully in {app_settings.APP_ENV} environment",
data={"app_name": app_settings.APP_NAME, "environment": app_settings.APP_ENV}
)
# Consumer registration first
await self.sms_handler.register_consumer()
await self.email_handler.register_consumer()
# Note: If we want startup logging for audit purposes,
# it should be done AFTER all critical startup is complete
# and database is ready. Currently keeping minimal startup.
@self.on_event("shutdown")
async def stop_consumers():

1
apps/payment/webapi/bootstrap/application.py
View File

@ -12,7 +12,6 @@ from webapi.providers import probes
from webapi.providers import exception_handler
from .freeleaps_app import FreeleapsApp
from common.config.app_settings import app_settings
from common.log.module_logger import ModuleLogger
def create_app() -> FastAPI:
logging.info("App initializing")

12
apps/payment/webapi/bootstrap/freeleaps_app.py
View File

@ -1,18 +1,6 @@
from fastapi import FastAPI
from common.log.module_logger import ModuleLogger
from common.config.app_settings import app_settings
class FreeleapsApp(FastAPI):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.register_startup_event()
def register_startup_event(self):
@self.on_event("startup")
async def startup_logging():
module_logger = ModuleLogger(sender_id="ApplicationBootstrap")
await module_logger.log_info(
text=f"Payment service started successfully in {app_settings.APP_ENV} environment",
data={"app_name": app_settings.APP_NAME, "environment": app_settings.APP_ENV}
)